MDEV-39459 Fix bad sync pattern for chain replication MTR tests#5084
Open
FarihaIS wants to merge 1 commit into
Open
MDEV-39459 Fix bad sync pattern for chain replication MTR tests#5084FarihaIS wants to merge 1 commit into
FarihaIS wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several replication tests to ensure proper synchronization across a multi-server topology (1->2->3). By explicitly syncing server_2 with the master's GTID before server_3, the tests now correctly account for the intermediate node in the replication chain. Feedback was provided regarding the deletion of the rpl_extra_col_slave_rebinlog.test file, requesting clarification on why it was removed instead of being updated with the new synchronization pattern.
FarihaIS
force-pushed
the
mdev-39459-12.3
branch
2 times, most recently
from
c6e12d7 to
1164902
Compare
1 task
In chain replication (1->2->3), syncing only server_3 after save_master_gtid on server_1 does not guarantee server_2 has committed, because server_2's binlog dump thread can send events to server_3 before commit_ordered() completes on server_2. Fix affected rpl tests by syncing server_2 before server_3, and update result files accordingly. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In chain replication (1->2->3), several rpl MTR tests synchronize by calling
save_master_gtidonserver_1followed bysync_with_master_gtidonserver_3, skippingserver_2.This is unsafe because
server_2's binlog dump thread can send events toserver_3beforecommit_ordered()completes onserver_2. Any operations onserver_2that depend on the replicated data can then fail intermittently.Fix by explicitly syncing
server_2beforeserver_3in all affected tests, and update result files accordingly.Release Notes
N/A
How can this PR be tested?
Execute the rpl test suite in mysql-test-run:
Basing the PR against the correct MariaDB version
Copyright
All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.